mm/gup: do not return 0 from pin_user_pages_fast() for bad args
authorJason Gunthorpe <jgg@nvidia.com>
Mon, 19 Jun 2023 18:27:25 +0000 (15:27 -0300)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 23 Jun 2023 23:59:27 +0000 (16:59 -0700)
commit9883c7f84053cec2826ca3c56254601b5ce9cdbe
treedcdc7f4040b01975d20303c37de21d5be2f66828
parent0b52c420350e8f9873ba62768cd8246827184408
mm/gup: do not return 0 from pin_user_pages_fast() for bad args

These routines are not intended to return zero, the callers cannot do
anything sane with a 0 return.  They should return an error which means
future calls to GUP will not succeed, or they should return some non-zero
number of pinned pages which means GUP should be called again.

If start + nr_pages overflows it should return -EOVERFLOW to signal the
arguments are invalid.

Syzkaller keeps tripping on this when fuzzing GUP arguments.

Link: https://lkml.kernel.org/r/0-v1-3d5ed1f20d50+104-gup_overflow_jgg@nvidia.com
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Reported-by: syzbot+353c7be4964c6253f24a@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/000000000000094fdd05faa4d3a4@google.com
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/gup.c