batman-adv: Hold rtnl lock during MTU update via netlink
authorSven Eckelmann <sven@narfation.org>
Mon, 21 Aug 2023 19:48:48 +0000 (21:48 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 23 Aug 2023 00:25:10 +0000 (17:25 -0700)
commit987aae75fc1041072941ffb622b45ce2359a99b9
treed6e3727e56c67b83ded6d42f358be5e61db89d1b
parentb888c510f7b3d64ca75fc0f43b4a4bd1a611312f
batman-adv: Hold rtnl lock during MTU update via netlink

The automatic recalculation of the maximum allowed MTU is usually triggered
by code sections which are already rtnl lock protected by callers outside
of batman-adv. But when the fragmentation setting is changed via
batman-adv's own batadv genl family, then the rtnl lock is not yet taken.

But dev_set_mtu requires that the caller holds the rtnl lock because it
uses netdevice notifiers. And this code will then fail the check for this
lock:

  RTNL: assertion failed at net/core/dev.c (1953)

Cc: stable@vger.kernel.org
Reported-by: syzbot+f8812454d9b3ac00d282@syzkaller.appspotmail.com
Fixes: c6a953cce8d0 ("batman-adv: Trigger events for auto adjusted MTU")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20230821-batadv-missing-mtu-rtnl-lock-v1-1-1c5a7bfe861e@narfation.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/batman-adv/netlink.c