leds: lm355x: avoid enum conversion warning
authorArnd Bergmann <arnd@arndb.de>
Tue, 5 May 2020 14:19:17 +0000 (16:19 +0200)
committerPavel Machek <pavel@ucw.cz>
Mon, 22 Jun 2020 08:37:57 +0000 (10:37 +0200)
commit985b1f596f9ed56f42b8c2280005f943e1434c06
tree5c5c02874b9e017c5c2e79baf23d2fc35b49e9fe
parent528c1d71ec954347fa240837e3c30ead0925dcb3
leds: lm355x: avoid enum conversion warning

clang points out that doing arithmetic between diffent enums is usually
a mistake:

drivers/leds/leds-lm355x.c:167:28: warning: bitwise operation between different enumeration types ('enum lm355x_tx2' and 'enum lm355x_ntc') [-Wenum-enum-conversion]
                reg_val = pdata->pin_tx2 | pdata->ntc_pin;
                          ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
drivers/leds/leds-lm355x.c:178:28: warning: bitwise operation between different enumeration types ('enum lm355x_tx2' and 'enum lm355x_ntc') [-Wenum-enum-conversion]
                reg_val = pdata->pin_tx2 | pdata->ntc_pin | pdata->pass_mode;
                          ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~

In this driver, it is intentional, so add a cast to hide the false-positive
warning. It appears to be the only instance of this warning at the moment.

Fixes: b98d13c72592 ("leds: Add new LED driver for lm355x chips")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-lm355x.c