block: fix wrong mode for blkdev_get_by_dev() from disk_scan_partitions()
authorYu Kuai <yukuai3@huawei.com>
Sun, 18 Jun 2023 14:04:02 +0000 (22:04 +0800)
committerJens Axboe <axboe@kernel.dk>
Tue, 20 Jun 2023 13:17:46 +0000 (07:17 -0600)
commit985958b8584cc143555f1bd735e7ab5066c944a7
tree376818f581df1bd6058ee53dcfdb00ef66ce42b7
parente89e001f24bf7bc558d9ebccb97fd559443021da
block: fix wrong mode for blkdev_get_by_dev() from disk_scan_partitions()

After commit 2736e8eeb0cc ("block: use the holder as indication for
exclusive opens"), blkdev_get_by_dev() will warn if holder is NULL and
mode contains 'FMODE_EXCL'.

holder from blkdev_get_by_dev() from disk_scan_partitions() is always NULL,
hence it should not use 'FMODE_EXCL', which is broben by the commit. For
consequence, WARN_ON_ONCE() will be triggered from blkdev_get_by_dev()
if user scan partitions with device opened exclusively.

Fix this problem by removing 'FMODE_EXCL' from disk_scan_partitions(),
as it used to be.

Reported-by: syzbot+00cd27751f78817f167b@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=00cd27751f78817f167b
Fixes: 2736e8eeb0cc ("block: use the holder as indication for exclusive opens")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Christian Brauner <brauner@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20230618140402.7556-1-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/genhd.c