[lldb] Set return object failed status even if error string is empty
authorDavid Spickett <david.spickett@linaro.org>
Wed, 16 Jun 2021 13:39:50 +0000 (14:39 +0100)
committerDavid Spickett <david.spickett@linaro.org>
Thu, 17 Jun 2021 11:20:52 +0000 (12:20 +0100)
commit983ed1b58ef9d0f97c9cec2876f631e47609d437
tree8557576ced6779a1bd6eb01ffcaabce1651b990f
parentd7e891213444e2990397c623fb0250a470421fce
[lldb] Set return object failed status even if error string is empty

The idea is now that AppendError<...> will set eReturnStatusFailed
for you so you don't have to call SetStatus again.

Previously if the error message was empty, the status wouldn't
be set.

I don't think there are any sitautions where the message is in
fact empty but it potentially could be depending on where
we get the string from.

So let's set the status up front then return early if the message is empty.

Reviewed By: teemperor

Differential Revision: https://reviews.llvm.org/D104380
lldb/source/Interpreter/CommandReturnObject.cpp