scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND
authorJan Kara <jack@suse.cz>
Thu, 23 Oct 2014 02:13:39 +0000 (20:13 -0600)
committerZefan Li <lizefan@huawei.com>
Mon, 2 Feb 2015 09:05:03 +0000 (17:05 +0800)
commit981cf05b831a41bf4e73ee557d404568907f36ff
tree8f757c1c4dbb25dbcf04bce63abcb62203983c4d
parent69fd3543d6eb6150af2d5f712f01a1452a9a2b78
scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND

commit 84ce0f0e94ac97217398b3b69c21c7a62ebeed05 upstream.

When sg_scsi_ioctl() fails to prepare request to submit in
blk_rq_map_kern() we jump to a label where we just end up copying
(luckily zeroed-out) kernel buffer to userspace instead of reporting
error. Fix the problem by jumping to the right label.

CC: Jens Axboe <axboe@kernel.dk>
CC: linux-scsi@vger.kernel.org
Coverity-id: 1226871
Signed-off-by: Jan Kara <jack@suse.cz>
Fixed up the, now unused, out label.

Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Zefan Li <lizefan@huawei.com>
block/scsi_ioctl.c