workqueue: use WARN_ON_FUNCTION_MISMATCH
authorSami Tolvanen <samitolvanen@google.com>
Thu, 8 Apr 2021 18:28:30 +0000 (11:28 -0700)
committerKees Cook <keescook@chromium.org>
Thu, 8 Apr 2021 23:04:21 +0000 (16:04 -0700)
commit981731129e0fc1d3aa3213195904c9bf45fa9f36
tree3171968b4ed89ce5fda2e5ad1513fbb4349ec774
parent28aad1c29053195b1a9f56742e64b679d61e786b
workqueue: use WARN_ON_FUNCTION_MISMATCH

With CONFIG_CFI_CLANG, a callback function passed to
__queue_delayed_work from a module points to a jump table entry
defined in the module instead of the one used in the core kernel,
which breaks function address equality in this check:

  WARN_ON_ONCE(timer->function != delayed_work_timer_fn);

Use WARN_ON_FUNCTION_MISMATCH() instead to disable the warning
when CFI and modules are both enabled.

Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20210408182843.1754385-6-samitolvanen@google.com
kernel/workqueue.c