platform/x86: hp-bioscfg: Fix reference leak
authorArmin Wolf <W_Armin@gmx.de>
Mon, 25 Sep 2023 14:28:19 +0000 (16:28 +0200)
committerHans de Goede <hdegoede@redhat.com>
Wed, 4 Oct 2023 09:52:30 +0000 (11:52 +0200)
commit981368e1440b76f68b1ac8f5fb14e739f80ecc4e
tree8babe9d9c326d14e4fd1858d559862d0af2f3e79
parent528ab3e605cabf2f9c9bd5944d3bfe15f6e94f81
platform/x86: hp-bioscfg: Fix reference leak

If a duplicate attribute is found using kset_find_obj(), a reference
to that attribute is returned which needs to be disposed accordingly
using kobject_put(). Use kobject_put() to dispose the duplicate
attribute in such a case.
As a side note, a very similar bug was fixed in
commit 7295a996fdab ("platform/x86: dell-sysman: Fix reference leak"),
so it seems that the bug was copied from that driver.

Compile-tested only.

Fixes: a34fc329b189 ("platform/x86: hp-bioscfg: bioscfg")
Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Jorge Lopez <jorge.lopez2@hp.com>
Link: https://lore.kernel.org/r/20230925142819.74525-3-W_Armin@gmx.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/hp/hp-bioscfg/bioscfg.c