x86 debug address register clarifications
authorGary Benson <gbenson@redhat.com>
Wed, 3 Sep 2014 11:05:50 +0000 (12:05 +0100)
committerGary Benson <gbenson@redhat.com>
Wed, 3 Sep 2014 11:40:49 +0000 (12:40 +0100)
commit97ea6506c45ab5519483a0221fdc049038496492
tree4aeebec2dfe700ec41d33ba803a88dbb7aa33e27
parentd14378154883eb1ae5373e7a73edcc9d97e62634
x86 debug address register clarifications

The loop macro ALL_DEBUG_REGISTERS does not iterate over the status or
control registers, so its name is misleading.  This commit renames it
as ALL_DEBUG_ADDRESS_REGISTERS and updates all uses.  This commit also
updates its loop conditions to an equivalent but better form, and
makes two functions use it that had previously hardwired the loop.
A comment on a related field in the x86_debug_reg_state structure is
also updated to reflect that the field refers specifically to address
registers only.

gdb/ChangeLog:

* nat/x86-dregs.h (ALL_DEBUG_REGISTERS): Renamed as...
(ALL_DEBUG_ADDRESS_REGISTERS): New macro.  All uses updated.
Loop conditions changed to equivalent form.
(struct x86_debug_reg_state): Updated dr_ref_count comment.
* x86-linux-nat.c (x86_linux_prepare_to_resume): Use
ALL_DEBUG_ADDRESS_REGISTERS.

gdb/gdbserver/ChangeLog:

* linux-x86-low.c (x86_linux_prepare_to_resume): Use
ALL_DEBUG_ADDRESS_REGISTERS.
gdb/ChangeLog
gdb/gdbserver/ChangeLog
gdb/gdbserver/linux-x86-low.c
gdb/gdbserver/x86-low.c
gdb/nat/x86-dregs.c
gdb/nat/x86-dregs.h
gdb/x86-linux-nat.c