USB: cdc-acm: fix write and resume race
authorJohan Hovold <jhovold@gmail.com>
Mon, 26 May 2014 17:23:37 +0000 (19:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Jun 2014 19:10:28 +0000 (15:10 -0400)
commit97e72c4aa615b5ed6a7c4b22b9fa766679c749bc
treec8a603bec68619b2a36d8317324f423a795720b8
parentbe7978bb5b91ef7168a93cf91acd672dfb65f0d0
USB: cdc-acm: fix write and resume race

commit e144ed28bed10684f9aaec6325ed974d53f76110 upstream.

Fix race between write() and resume() due to improper locking that could
lead to writes being reordered.

Resume must be done atomically and susp_count be protected by the
write_lock in order to prevent racing with write(). This could otherwise
lead to writes being reordered if write() grabs the write_lock after
susp_count is decremented, but before the delayed urb is submitted.

Fixes: 11ea859d64b6 ("USB: additional power savings for cdc-acm devices
that support remote wakeup")

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/cdc-acm.c