soc: ti: Fix reference imbalance in knav_dma_probe
authorZhang Qilong <zhangqilong3@huawei.com>
Sun, 22 Nov 2020 03:22:37 +0000 (19:22 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:53:18 +0000 (11:53 +0100)
commit97d14d592159a34f73bda07d925a2925f90a35ea
treeb91969aa3074a0a12ea5e22992bae48f38f53255
parentbdf76d879ac372ef7c04af353fd2ee56e5f6f10d
soc: ti: Fix reference imbalance in knav_dma_probe

[ Upstream commit b4fa73358c306d747a2200aec6f7acb97e5750e6 ]

The patch fix two reference leak.

  1) pm_runtime_get_sync will increment pm usage counter even it
     failed. Forgetting to call put operation will result in
     reference leak.

  2) The pm_runtime_enable will increase power disable depth. Thus
     a pairing decrement is needed on the error handling path to
     keep it balanced.

We fix it by: 1) adding call pm_runtime_put_noidle or
pm_runtime_put_sync in error handling. 2) adding pm_runtime_disable
in error handling, to keep usage counter and disable depth balanced.

Fixes: 88139ed030583 ("soc: ti: add Keystone Navigator DMA support")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/ti/knav_dma.c