Fix signed/unsigned pointer warning
authorKevin Cernekee <cernekee@gmail.com>
Mon, 10 Nov 2014 21:09:23 +0000 (13:09 -0800)
committerSteve French <steve.french@primarydata.com>
Sun, 14 Dec 2014 20:55:57 +0000 (14:55 -0600)
commit97c7134ae22fbd2b8730211f9d4d4517264a8efe
treebb59df354df66cdfcb1a58f9940c7ebd0ccf3467
parent9235d09873316d602937b5d45c431fb653f3aed8
Fix signed/unsigned pointer warning

Commit 2ae83bf93882d1 ("[CIFS] Fix setting time before epoch (negative
time values)") changed "u64 t" to "s64 t", which makes do_div() complain
about a pointer signedness mismatch:

      CC      fs/cifs/netmisc.o
    In file included from ./arch/mips/include/asm/div64.h:12:0,
                     from include/linux/kernel.h:124,
                     from include/linux/list.h:8,
                     from include/linux/wait.h:6,
                     from include/linux/net.h:23,
                     from fs/cifs/netmisc.c:25:
    fs/cifs/netmisc.c: In function ‘cifs_NTtimeToUnix’:
    include/asm-generic/div64.h:43:28: warning: comparison of distinct pointer types lacks a cast [enabled by default]
      (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
                                ^
    fs/cifs/netmisc.c:941:22: note: in expansion of macro ‘do_div’
       ts.tv_nsec = (long)do_div(t, 10000000) * 100;

Introduce a temporary "u64 abs_t" variable to fix this.

Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
Signed-off-by: Steve French <steve.french@primarydata.com>
fs/cifs/netmisc.c