net/mlx5: Skip inline mode check after mlx5_eswitch_enable_locked() failure
authorJiri Pirko <jiri@nvidia.com>
Tue, 6 Jun 2023 07:12:17 +0000 (00:12 -0700)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 7 Jun 2023 21:00:44 +0000 (14:00 -0700)
commit97bd788efb9052963b43ba41c8aaff3ed12e1ede
tree9edd9522e133a67a62358425b150e0e84682157a
parentde1f0a650824ed1905d5d48190f65f309cee5163
net/mlx5: Skip inline mode check after mlx5_eswitch_enable_locked() failure

Commit bffaa916588e ("net/mlx5: E-Switch, Add control for inline mode")
added inline mode checking to esw_offloads_start() with a warning
printed out in case there is a problem. Tne inline mode checking was
done even after mlx5_eswitch_enable_locked() call failed, which is
pointless.

Later on, commit 8c98ee77d911 ("net/mlx5e: E-Switch, Add extack messages
to devlink callbacks") converted the error/warning prints to extack
setting, which caused that the inline mode check error to overwrite
possible previous extack message when mlx5_eswitch_enable_locked()
failed. User then gets confusing error message.

Fix this by skipping check of inline mode after
mlx5_eswitch_enable_locked() call failed.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c