Eliminate more warnings.
authorTimothy B. Terriberry <tterribe@xiph.org>
Wed, 27 Oct 2010 23:04:02 +0000 (16:04 -0700)
committerJohn Koleszar <jkoleszar@google.com>
Thu, 28 Oct 2010 12:26:03 +0000 (08:26 -0400)
commit97b766a46cb7a9a26da618726600e619023c0745
tree78b10dbca31d34f2b4a038774708eb2ce218f344
parent6fda7668e84808230d69a9d1f7580bd4b14ff977
Eliminate more warnings.

This eliminates a large set of warnings exposed by the Mozilla build
 system (Use of C++ comments in ISO C90 source, commas at the end of
 enum lists, a couple incomplete initializers, and signed/unsigned
 comparisons).
It also eliminates many (but not all) of the warnings expose by newer
 GCC versions and _FORTIFY_SOURCE (e.g., calling fread and fwrite
 without checking the return values).
There are a few spurious warnings left on my system:

../vp8/encoder/encodemb.c:274:9: warning: 'sz' may be used
 uninitialized in this function
gcc seems to be unable to figure out that the value shortcut doesn't
 change between the two if blocks that test it here.

../vp8/encoder/onyx_if.c:5314:5: warning: comparison of unsigned
 expression >= 0 is always true
../vp8/encoder/onyx_if.c:5319:5: warning: comparison of unsigned
 expression >= 0 is always true
This is true, so far as it goes, but it's comparing against an enum,
 and the C standard does not mandate that enums be unsigned, so the
 checks can't be removed.

Change-Id: Iead6cd561a2afaa3d801fd63f1d8d58953da7426
74 files changed:
examples/decoder_tmpl.c
examples/decoder_tmpl.txt
examples/encoder_tmpl.c
examples/encoder_tmpl.txt
libmkv/EbmlIDs.h
vp8/common/alloccommon.c
vp8/common/arm/bilinearfilter_arm.c
vp8/common/arm/filter_arm.c
vp8/common/arm/loopfilter_arm.c
vp8/common/arm/neon/recon_neon.c
vp8/common/blockd.h
vp8/common/debugmodes.c
vp8/common/defaultcoefcounts.h
vp8/common/entropy.h
vp8/common/entropymv.c
vp8/common/extend.c
vp8/common/filter_c.c
vp8/common/findnearmv.c
vp8/common/generic/systemdependent.c
vp8/common/invtrans.c
vp8/common/loopfilter.c
vp8/common/loopfilter.h
vp8/common/loopfilter_filters.c
vp8/common/mbpitch.c
vp8/common/modecont.c
vp8/common/modecontext.c
vp8/common/onyxc_int.h
vp8/common/postproc.c
vp8/common/ppflags.h
vp8/common/recon.c
vp8/common/recon.h
vp8/common/reconinter.c
vp8/common/reconintra.c
vp8/common/reconintra4x4.c
vp8/common/setupintrarecon.c
vp8/common/textblit.c
vp8/common/threading.h
vp8/common/treecoder.h
vp8/common/type_aliases.h
vp8/common/x86/loopfilter_x86.c
vp8/common/x86/vp8_asm_stubs.c
vp8/common/x86/x86_systemdependent.c
vp8/decoder/arm/arm_dsystemdependent.c
vp8/decoder/arm/dboolhuff_arm.h
vp8/decoder/dboolhuff.h
vp8/decoder/decodemv.c
vp8/decoder/decodframe.c
vp8/decoder/dequantize.c
vp8/decoder/detokenize.c
vp8/decoder/generic/dsystemdependent.c
vp8/decoder/onyxd_if.c
vp8/decoder/onyxd_int.h
vp8/decoder/reconintra_mt.c
vp8/decoder/reconintra_mt.h
vp8/decoder/threading.c
vp8/encoder/firstpass.c
vp8/vp8_dx_iface.c
vpx/src/vpx_encoder.c
vpx/vp8.h
vpx/vpx_codec.h
vpx/vpx_decoder_compat.h
vpx/vpx_encoder.h
vpx/vpx_image.h
vpx_mem/include/vpx_mem_intrnl.h
vpx_mem/vpx_mem.c
vpx_mem/vpx_mem.h
vpx_scale/generic/gen_scalers.c
vpx_scale/generic/vpxscale.c
vpx_scale/generic/yv12config.c
vpx_scale/generic/yv12extend.c
vpx_scale/yv12config.h
vpxdec.c
vpxenc.c
y4minput.c