dmaengine: omap-dma: Fix memory leak when terminating running transfer
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Fri, 27 Mar 2015 11:35:52 +0000 (13:35 +0200)
committerSasha Levin <sasha.levin@oracle.com>
Fri, 24 Apr 2015 21:13:54 +0000 (17:13 -0400)
commit9786bf2b3aae9e17ca706d4357fe2bc169aa41dd
treebc09062daf70350c091dd502199a64e2b9dcbd83
parentba1d2d92c3dae111c25824f0f44405df455c9e4f
dmaengine: omap-dma: Fix memory leak when terminating running transfer

[ Upstream commit 02d88b735f5a60f04dbf6d051b76e1877a0d0844 ]

In omap_dma_start_desc the vdesc->node is removed from the virt-dma
framework managed lists (to be precise from the desc_issued list).
If a terminate_all comes before the transfer finishes the omap_desc will
not be freed up because it is not in any of the lists and we stopped the
DMA channel so the transfer will not going to complete.
There is no special sequence for leaking memory when using cyclic (audio)
transfer: with every start and stop of a cyclic transfer the driver leaks
struct omap_desc worth of memory.

Free up the allocated memory directly in omap_dma_terminate_all() since the
framework will not going to do that for us.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
CC: <stable@vger.kernel.org>
CC: <linux-omap@vger.kernel.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/dma/omap-dma.c