writeback: fix dereferencing NULL bdi->dev on trace_writeback_queue
authorWu Fengguang <fengguang.wu@intel.com>
Sun, 5 Feb 2012 02:54:03 +0000 (20:54 -0600)
committerWu Fengguang <fengguang.wu@intel.com>
Mon, 6 Feb 2012 03:17:25 +0000 (11:17 +0800)
commit977b7e3a52a7421ad33a393a38ece59f3d41c2fa
tree8ad7bb97c2385c3407c4fb647cc932978057559d
parent3310225dfc71a35a2cc9340c15c0e08b14b3c754
writeback: fix dereferencing NULL bdi->dev on trace_writeback_queue

When a SD card is hot removed without umount, del_gendisk() will call
bdi_unregister() without destroying/freeing it. This leaves the bdi in
the bdi->dev = NULL, bdi->wb.task = NULL, bdi->bdi_list removed state.

When sync(2) gets the bdi before bdi_unregister() and calls
bdi_queue_work() after the unregister, trace_writeback_queue will be
dereferencing the NULL bdi->dev. Fix it with a simple test for NULL.

LKML-reference: http://lkml.org/lkml/2012/1/18/346
Cc: stable@kernel.org
Reported-by: Rabin Vincent <rabin@rab.in>
Tested-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
include/trace/events/writeback.h