PM / Domains: defer dev_pm_domain_set() until genpd->attach_dev succeeds if present
authorSudeep Holla <Sudeep.Holla@arm.com>
Fri, 14 Jul 2017 10:51:48 +0000 (11:51 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 19 Jul 2017 12:41:11 +0000 (14:41 +0200)
commit975e83cfb8dc16e7a2fdc58188c77c0c605876c2
treed02e4cc1e92ca48779ae8010486562de99cdd88d
parentaf3eb27433356ed4b6e124fd446a425a0ccf4e49
PM / Domains: defer dev_pm_domain_set() until genpd->attach_dev succeeds if present

If the genpd->attach_dev or genpd->power_on fails, genpd_dev_pm_attach
may return -EPROBE_DEFER initially. However genpd_alloc_dev_data sets
the PM domain for the device unconditionally.

When subsequent attempts are made to call genpd_dev_pm_attach, it may
return -EEXISTS checking dev->pm_domain without re-attempting to call
attach_dev or power_on.

platform_drv_probe then attempts to call drv->probe as the return value
-EEXIST != -EPROBE_DEFER, which may end up in a situation where the
device is accessed without it's power domain switched on.

Fixes: f104e1e5ef57 (PM / Domains: Re-order initialization of generic_pm_domain_data)
Cc: 4.4+ <stable@vger.kernel.org> # v4.4+
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/power/domain.c