ath10k: Fix error handling in ath10k_setup_msa_resources
authorMiaoqian Lin <linmq006@gmail.com>
Tue, 8 Mar 2022 07:02:38 +0000 (07:02 +0000)
committerKalle Valo <quic_kvalo@quicinc.com>
Thu, 10 Mar 2022 15:52:18 +0000 (17:52 +0200)
commit9747a78d5f758a5284751a10aee13c30d02bd5f1
treeb0f38602f6dc9d574d0b51ab7cd0a989e5d442c7
parent57fe207f752a95e1929e242dfdb21c6dac741e0d
ath10k: Fix error handling in ath10k_setup_msa_resources

The device_node pointer is returned by of_parse_phandle() with refcount
incremented. We should use of_node_put() on it when done.

This function only calls of_node_put() in the regular path.
And it will cause refcount leak in error path.

Fixes: 727fec790ead ("ath10k: Setup the msa resources before qmi init")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20220308070238.19295-1-linmq006@gmail.com
drivers/net/wireless/ath/ath10k/snoc.c