Rename QMetaMethod::signature() to methodSignature()
authorKent Hansen <kent.hansen@nokia.com>
Sat, 18 Feb 2012 22:16:24 +0000 (23:16 +0100)
committerQt by Nokia <qt-info@nokia.com>
Wed, 29 Feb 2012 11:50:14 +0000 (12:50 +0100)
commit96f2365cf4cebc074c3171878dcd25ce19ee7486
tree188bde357226f7c86adf11618bbaac8e53020f97
parent3f7a222414fc9d3e9f2e2cfdd05f33740c5afb7e
Rename QMetaMethod::signature() to methodSignature()

In Qt5 the meta-data format will be changed to not store the
method signature string explicitly; the signature will be
reconstructed on demand from the method name and parameter type
information.

The QMetaMethod::signature() method returns a const char pointer.
Changing the return type to QByteArray can lead to silent bugs due to
the implicit conversion to char *. Even though it's a source-
incompatible change, it's therefore better to introduce a new
function, methodSignature(), and remove the old signature().

Task-number: QTBUG-24154
Change-Id: Ib3579dedd27a3c7c8914d5f1b231947be2cf4027
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
23 files changed:
dist/changes-5.0.0
doc/src/snippets/code/src_corelib_kernel_qmetaobject.cpp
src/corelib/kernel/qmetaobject.cpp
src/corelib/kernel/qmetaobject.h
src/corelib/kernel/qmetaobjectbuilder.cpp
src/corelib/kernel/qobject.cpp
src/corelib/statemachine/qstatemachine.cpp
src/dbus/qdbusabstractadaptor.cpp
src/dbus/qdbusabstractinterface.cpp
src/dbus/qdbusintegrator.cpp
src/dbus/qdbusmisc.cpp
src/dbus/qdbusxmlgenerator.cpp
src/gui/accessible/qaccessibleobject.cpp
src/testlib/qsignaldumper.cpp
src/testlib/qtestcase.cpp
tests/auto/corelib/kernel/qmetamethod/tst_qmetamethod.cpp
tests/auto/corelib/kernel/qmetaobject/tst_qmetaobject.cpp
tests/auto/corelib/kernel/qmetaobjectbuilder/tst_qmetaobjectbuilder.cpp
tests/auto/corelib/kernel/qobject/tst_qobject.cpp
tests/auto/dbus/qdbusmetaobject/tst_qdbusmetaobject.cpp
tests/auto/tools/moc/tst_moc.cpp
tests/auto/widgets/widgets/qmdiarea/tst_qmdiarea.cpp
tests/benchmarks/corelib/kernel/qmetaobject/main.cpp