[libc++][test] Silence MSVC warning
authorCasey Carter <Casey@Carter.net>
Mon, 9 Jan 2023 09:38:14 +0000 (01:38 -0800)
committerCasey Carter <Casey@Carter.net>
Mon, 9 Jan 2023 23:05:31 +0000 (15:05 -0800)
commit96f1cd2427e472acf65e1b0b755a2c1f672e730b
treec35f269fd7caee9baae986b79d531287b8bf748c
parentf8d7ab8cf8e859dcc7f696e8d01ed6fca502446a
[libc++][test] Silence MSVC warning

Our static analyzer likes to warn when loop bodies are never executed, which is true for `make_string<T>("")`. Build the result with `basic_string`'s iterator-pair constructor instead, which is simpler (one liner), faster (single pass), and doesn't trigger the warning.

Differential Revision: https://reviews.llvm.org/D141263
libcxx/test/std/ranges/range.factories/range.istream.view/utils.h