buffer: changing let in for loops back to var
authorGareth Ellis <gareth.ellis@uk.ibm.com>
Mon, 21 Mar 2016 09:46:42 +0000 (09:46 +0000)
committerMyles Borins <mborins@us.ibm.com>
Wed, 30 Mar 2016 20:12:17 +0000 (13:12 -0700)
commit96e163a79f15c47663a9505f25b3d9ca0b30f71c
treefde5be35054651a9a63c005feacf5f98186132e6
parent8c24bd25a6c6b4c92f8f7f6b4626de9b1c942516
buffer: changing let in for loops back to var

Using let in for loops showed a regression in 4.4.0. @ofrobots
suggested that we avoid using let in for loops until TurboFan becomes
the default optimiser.

The regression that was detected was when looking at how long it took
to create a new buffer from an array of data.

When using `for (let i=0; i<length; i++) ` we saw the operation take
almost 40% longer compared to `var i=0`.

PR-URL: https://github.com/nodejs/node/pull/5819
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Trevor Norris <trevnorris@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Ref: http://github.com/nodejs/benchmarking/issues/38
lib/buffer.js