fix bug in block-qcow2.c:alloc_cluster_offset() (Shahar Frank)
authoraliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
Wed, 24 Sep 2008 16:52:15 +0000 (16:52 +0000)
committeraliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
Wed, 24 Sep 2008 16:52:15 +0000 (16:52 +0000)
commit96de2466b448387b1e3be5a3c142cbf5ed2da41d
treed1f80ea8e2dda8a5c1c52f6a29c06b46d808ae43
parent0af5183ae445356f99989a25ebc2e9ec86796c2f
fix bug in block-qcow2.c:alloc_cluster_offset() (Shahar Frank)

During the debugging of the new revision of the zero dedup patch I
stepped on the following bug in block-qcow2.c:alloc_cluster_offset(). I
am not sure what the exact damage this bug can do, but it may be very
nasty because you way not notice it effects until you will do some
snapshot operations or similar actions that rely on the reference
counting.

The bug is easy to spot using the new "check" verb I added to the
qemu-img in one of the previous patches. I will resend the qemu-img
patch again with the new version of the zero dedup.

Signed-off-by: Shahar Frank <shaharf@qumranet.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5313 c046a42c-6fe2-441c-8c8c-71466251a162
block-qcow2.c