drm/amd/display: check attr flag before set cursor degamma on DCN3+
authorMelissa Wen <mwen@igalia.com>
Mon, 31 Jul 2023 08:35:05 +0000 (07:35 -0100)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 9 Aug 2023 14:41:19 +0000 (10:41 -0400)
commit96b020e2163fb2197266b2f71b1007495206e6bb
tree3418475a3721db3b94fcb9f9c56e8066a4b5ac36
parent61319b8e3b58a7167cf146313fd4523fe72586bc
drm/amd/display: check attr flag before set cursor degamma on DCN3+

Don't set predefined degamma curve to cursor plane if the cursor
attribute flag is not set. Applying a degamma curve to the cursor by
default breaks userspace expectation. Checking the flag before
performing any color transformation prevents too dark cursor gamma in
DCN3+ on many Linux desktop environment (KDE Plasma, GNOME,
wlroots-based, etc.) as reported at:
- https://gitlab.freedesktop.org/drm/amd/-/issues/1513

This is the same approach followed by DCN2 drivers where the issue is
not present.

Fixes: 03f54d7d3448 ("drm/amd/display: Add DCN3 DPP")
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1513
Signed-off-by: Melissa Wen <mwen@igalia.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Tested-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c