mm: zswap: fix pool refcount bug around shrink_worker()
authorJohannes Weiner <hannes@cmpxchg.org>
Fri, 6 Oct 2023 16:00:24 +0000 (12:00 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 18 Oct 2023 19:12:40 +0000 (12:12 -0700)
commit969d63e1af3b3abe35a49b08218f3125131ac32f
tree9795ec5405ccfeeec191bdfc7689caa9d30e567e
parent229e2253766c7cdfe024f1fe280020cc4711087c
mm: zswap: fix pool refcount bug around shrink_worker()

When a zswap store fails due to the limit, it acquires a pool reference
and queues the shrinker.  When the shrinker runs, it drops the reference.
However, there can be multiple store attempts before the shrinker wakes up
and runs once.  This results in reference leaks and eventual saturation
warnings for the pool refcount.

Fix this by dropping the reference again when the shrinker is already
queued.  This ensures one reference per shrinker run.

Link: https://lkml.kernel.org/r/20231006160024.170748-1-hannes@cmpxchg.org
Fixes: 45190f01dd40 ("mm/zswap.c: add allocation hysteresis if pool limit is hit")
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reported-by: Chris Mason <clm@fb.com>
Acked-by: Nhat Pham <nphamcs@gmail.com>
Cc: Vitaly Wool <vitaly.wool@konsulko.com>
Cc: Domenico Cerasuolo <cerasuolodomenico@gmail.com>
Cc: <stable@vger.kernel.org> [5.6+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/zswap.c