efi: fix potential NULL deref in efi_mem_reserve_persistent
authorAnton Gusev <aagusev@ispras.ru>
Fri, 3 Feb 2023 13:22:13 +0000 (16:22 +0300)
committerArd Biesheuvel <ardb@kernel.org>
Fri, 3 Feb 2023 13:52:10 +0000 (14:52 +0100)
commit966d47e1f27c45507c5df82b2a2157e5a4fd3909
treeb43fa4ec2c1693a7a2ea380503df9aebe8c23bc7
parent636ab417a7aec4ee993916e688eb5c5977570836
efi: fix potential NULL deref in efi_mem_reserve_persistent

When iterating on a linked list, a result of memremap is dereferenced
without checking it for NULL.

This patch adds a check that falls back on allocating a new page in
case memremap doesn't succeed.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 18df7577adae ("efi/memreserve: deal with memreserve entries in unmapped memory")
Signed-off-by: Anton Gusev <aagusev@ispras.ru>
[ardb: return -ENOMEM instead of breaking out of the loop]
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
drivers/firmware/efi/efi.c