libbpf: Fix negative FD close() in xsk_setup_xdp_prog()
authorAndrii Nakryiko <andriin@fb.com>
Thu, 7 Nov 2019 05:40:59 +0000 (21:40 -0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 7 Nov 2019 15:15:27 +0000 (16:15 +0100)
commit9656b346b280c3e49c8a116c3a715f966633b161
tree67930b0a4a9a805df41fb87b1905806f69db7f8d
parentdab2e9eb187cb53c951c0c556172a73ac7f0e834
libbpf: Fix negative FD close() in xsk_setup_xdp_prog()

Fix issue reported by static analysis (Coverity). If bpf_prog_get_fd_by_id()
fails, xsk_lookup_bpf_maps() will fail as well and clean-up code will attempt
close() with fd=-1. Fix by checking bpf_prog_get_fd_by_id() return result and
exiting early.

Fixes: 10a13bb40e54 ("libbpf: remove qidconf and better support external bpf programs.")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20191107054059.313884-1-andriin@fb.com
tools/lib/bpf/xsk.c