HID: hid-uclogic-params: Invalid parameter check in uclogic_params_get_str_desc
authorJosé Expósito <jose.exposito89@gmail.com>
Wed, 5 Jan 2022 17:29:13 +0000 (18:29 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:03:54 +0000 (11:03 +0100)
commit964e6a78cb1df2ca1a4ec92bd6159ff93483032d
tree85ddb3f05ffd5a93257d41352d0745fc501cb69f
parent621aade97324398e74e8cd921fc02fc015e1d606
HID: hid-uclogic-params: Invalid parameter check in uclogic_params_get_str_desc

[ Upstream commit 0a94131d6920916ccb6a357037c535533af08819 ]

The function performs a check on the hdev input parameters, however, it
is used before the check.

Initialize the udev variable after the sanity check to avoid a
possible NULL pointer dereference.

Fixes: 9614219e9310e ("HID: uclogic: Extract tablet parameter discovery into a module")
Addresses-Coverity-ID: 1443827 ("Null pointer dereference")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-uclogic-params.c