drm/i915: Move fd_install after last use of fence
authorRob Clark <robdclark@chromium.org>
Fri, 3 Feb 2023 16:49:20 +0000 (08:49 -0800)
committerTvrtko Ursulin <tvrtko.ursulin@intel.com>
Mon, 6 Feb 2023 09:38:54 +0000 (09:38 +0000)
commit960dafa30455450d318756a9896a02727f2639e0
tree4f4bec50c5a41a67fad3874e9947e1c992ec6fac
parent01f0411f8e307e7154d062f62d4b0799b8498748
drm/i915: Move fd_install after last use of fence

Because eb_composite_fence_create() drops the fence_array reference
after creation of the sync_file, only the sync_file holds a ref to the
fence.  But fd_install() makes that reference visable to userspace, so
it must be the last thing we do with the fence.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Fixes: 00dae4d3d35d ("drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4)")
Cc: <stable@vger.kernel.org> # v5.15+
[tursulin: Added stable tag.]
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230203164937.4035503-1-robdclark@gmail.com
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c