netpoll: fix smatch warnings in netpoll core code
authorNeil Horman <nhorman@tuxdriver.com>
Wed, 13 Feb 2013 16:32:42 +0000 (11:32 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Feb 2013 16:56:46 +0000 (11:56 -0500)
commit959d5fdee7aa32fa04bc2c37e3d3871ad266fe97
tree85aed09aeaf78fd08d7254d3241ed35df032721d
parent99d5851eefe589346c976a4b539ee498267bc5fd
netpoll: fix smatch warnings in netpoll core code

Dan Carpenter contacted me with some notes regarding some smatch warnings in the
netpoll code, some of which I introduced with my recent netpoll locking fixes,
some which were there prior.   Specifically they were:

net-next/net/core/netpoll.c:243 netpoll_poll_dev() warn: inconsistent
  returns mutex:&ni->dev_lock: locked (213,217) unlocked (210,243)
net-next/net/core/netpoll.c:706 netpoll_neigh_reply() warn: potential
  pointer math issue ('skb_transport_header(send_skb)' is a 128 bit pointer)

This patch corrects the locking imbalance (the first error), and adds some
parenthesis to correct the second error.  Tested by myself. Applies to net-next

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Dan Carpenter <dan.carpenter@oracle.com>
CC: "David S. Miller" <davem@davemloft.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/netpoll.c