zram: take device and not only bvec offset into account
authorChristoph Hellwig <hch@lst.de>
Sat, 5 Aug 2023 05:55:37 +0000 (07:55 +0200)
committerJens Axboe <axboe@kernel.dk>
Sat, 5 Aug 2023 22:13:15 +0000 (16:13 -0600)
commit95848dcb9d676738411a8ff70a9704039f1b3982
tree685aae478a33f338677ec4e06c073173d1273c4b
parenta592ab6171bd943ce3b988bd271c79fe275a7bec
zram: take device and not only bvec offset into account

Commit af8b04c63708 ("zram: simplify bvec iteration in
__zram_make_request") changed the bio iteration in zram to rely on the
implicit capping to page boundaries in bio_for_each_segment.  But it
failed to care for the fact zram not only care about the page alignment
of the bio payload, but also the page alignment into the device.  For
buffered I/O and swap those are the same, but for direct I/O or kernel
internal I/O like XFS log buffer writes they can differ.

Fix this by open coding bio_for_each_segment and limiting the bvec len
so that it never crosses over a page alignment boundary in the device
in addition to the payload boundary already taken care of by
bio_iter_iovec.

Cc: stable@vger.kernel.org
Fixes: af8b04c63708 ("zram: simplify bvec iteration in __zram_make_request")
Reported-by: Dusty Mabe <dusty@dustymabe.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Link: https://lore.kernel.org/r/20230805055537.147835-1-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/zram/zram_drv.c