x86/boot/32: Flip the logic in test_wp_bit()
authorBorislav Petkov <bp@suse.de>
Thu, 30 Mar 2017 07:44:05 +0000 (09:44 +0200)
committerIngo Molnar <mingo@kernel.org>
Fri, 31 Mar 2017 06:08:31 +0000 (08:08 +0200)
commit952a6c2c094f4eda295f20c42e6e2d73735950fa
treeca6dc9a94f06011cb24660d7aa3de44a4e869a36
parent4af171105144a6475704c1e6024132883d50499e
x86/boot/32: Flip the logic in test_wp_bit()

... to have a natural "likely()" in the code flow and thus have the
success case with a branch 99.999% of the times non-taken and function
return code following it instead of jumping to it each time.

This puts the panic() call at the end of the function - it is going to
be practically unreachable anyway.

The C code is a bit more readable too.

No functionality change.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: boris.ostrovsky@oracle.com
Cc: jgross@suse.com
Cc: thgarnie@google.com
Link: http://lkml.kernel.org/r/20170330080101.ywsf5rg6ilzu4itk@pd.tnic
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/mm/init_32.c