firmware: arm_scmi: Fix null de-reference on error path
authorCristian Marussi <cristian.marussi@arm.com>
Fri, 12 Nov 2021 18:07:05 +0000 (18:07 +0000)
committerSudeep Holla <sudeep.holla@arm.com>
Mon, 15 Nov 2021 10:58:42 +0000 (10:58 +0000)
commit95161165727650a707bc34ecfac286a418b6bb00
tree4c9186bdc91e659a4cd620966d65b3b1261820b9
parentfa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf
firmware: arm_scmi: Fix null de-reference on error path

During channel setup a failure in the call of scmi_vio_feed_vq_rx() leads
to an attempt to access a dev pointer by dereferencing vioch->cinfo at
a time when vioch->cinfo has still to be initialized.

Fix it by providing the device reference directly to scmi_vio_feed_vq_rx.

Link: https://lore.kernel.org/r/20211112180705.41601-1-cristian.marussi@arm.com
Fixes: 46abe13b5e3db ("firmware: arm_scmi: Add virtio transport")
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/virtio.c