ALSA: pcm: Fix potential Spectre v1 vulnerability
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 12 Dec 2018 21:36:28 +0000 (15:36 -0600)
committerTakashi Iwai <tiwai@suse.de>
Thu, 13 Dec 2018 08:14:33 +0000 (09:14 +0100)
commit94ffb030b6d31ec840bb811be455dd2e26a4f43e
treede66c4b427f2f361df27e5cd5f0a84fd2ae41070
parent4aea96f4237cea0c51a8bc87c0db31f0f932f1f0
ALSA: pcm: Fix potential Spectre v1 vulnerability

stream is indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

sound/core/pcm.c:140 snd_pcm_control_ioctl() warn: potential spectre issue 'pcm->streams' [r] (local cap)

Fix this by sanitizing stream before using it to index pcm->streams

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: stable@vger.kernel.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm.c