crush: fix a bug in tree bucket decode
authorIlya Dryomov <idryomov@gmail.com>
Mon, 29 Jun 2015 16:30:23 +0000 (19:30 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Aug 2015 16:29:14 +0000 (09:29 -0700)
commit94fc30841d7d5f59957db6231100c5c07e7c0eab
tree81c4686963b5c8d2cbfc8d8e6649fa9c863e2691
parent650b07ba3c2382113a52f23581e861629476cca5
crush: fix a bug in tree bucket decode

commit 82cd003a77173c91b9acad8033fb7931dac8d751 upstream.

struct crush_bucket_tree::num_nodes is u8, so ceph_decode_8_safe()
should be used.  -Wconversion catches this, but I guess it went
unnoticed in all the noise it spews.  The actual problem (at least for
common crushmaps) isn't the u32 -> u8 truncation though - it's the
advancement by 4 bytes instead of 1 in the crushmap buffer.

Fixes: http://tracker.ceph.com/issues/2759

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ceph/osdmap.c