net: fix a potential rcu_read_lock() imbalance in rt6_fill_node()
authorEric Dumazet <eric.dumazet@gmail.com>
Tue, 27 Mar 2012 09:53:52 +0000 (09:53 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 27 Mar 2012 22:48:35 +0000 (18:48 -0400)
commit94f826b8076e2cb92242061e92f21b5baa3eccc2
treebb9893bf45ef93842a315b5ed8287ae1f11ae41b
parent50269e19ad990e79eeda101fc6df80cffd5d4831
net: fix a potential rcu_read_lock() imbalance in rt6_fill_node()

Commit f2c31e32b378 (net: fix NULL dereferences in check_peer_redir() )
added a regression in rt6_fill_node(), leading to rcu_read_lock()
imbalance.

Thats because NLA_PUT() can make a jump to nla_put_failure label.

Fix this by using nla_put()

Many thanks to Ben Greear for his help

Reported-by: Ben Greear <greearb@candelatech.com>
Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/route.c