projects / platform / upstream / libHarfBuzzSharp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2798ac1) | patch
Remove some use of Crap in hb-set.
authorBen Wagner <bungeman@chromium.org>
Thu, 25 Oct 2018 17:44:27 +0000 (13:44 -0400)
committerBehdad Esfahbod <behdad@behdad.org>
Thu, 25 Oct 2018 18:42:20 +0000 (11:42 -0700)
commit94e421abbfc7ede9aaf3c8d86bb0ff9992ea3123
treecc1dadd4f579293e5ed0ca3e1f04738e80cfa557tree | snapshot
parent2798ac1c28edc4ba6f2283784d1027393f588f8ccommit | diff
Remove some use of Crap in hb-set.

When hb_set_t::page_for_insert needs to insert at the end of the page_map
it ends up evaluating '&page_map[i + 1]' which has hb_vector return an
lvalue of a Crap so that nothing can be moved to its address. This turns
into issues with ThreadSanitizer on Crap when two threads modify different
hb_set_t instances. This can be avoided by using '&page_map[i] + 1'
instead.
src/hb-set.hh diff | blob | history
Domain: Dotnet / API;