pinctrl: nsp: Set irq handler based on trig type
authorMark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Fri, 3 Jul 2020 01:18:30 +0000 (13:18 +1200)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 11 Jul 2020 21:09:12 +0000 (23:09 +0200)
commit94c70241efbb1e7e008d433d3b020808f1984330
treef233e34f51f7f8b0c47ed3ae2d2497cd21df08b2
parent5f4962dd55d86d6a3ba5ddbfaf2d793e3b676a20
pinctrl: nsp: Set irq handler based on trig type

Rather than always using handle_simple_irq() as the gpio_irq_chip
handler, set a more appropriate handler based on the IRQ trigger type
requested. This is important for level triggered interrupts which need
to be masked during handling. Also, fix the interrupt acknowledge so
that it clears only one interrupt instead of all interrupts which are
currently active. Finally there is no need to clear the interrupt during
the interrupt handler, since the edge-triggered handler will do that for
us.

Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Link: https://lore.kernel.org/r/20200703011830.15655-1-mark.tomlinson@alliedtelesis.co.nz
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c