Linux: Only generate 64 bit timestamps for 64 bit time_t recvmsg/recvmmsg
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Thu, 27 Jan 2022 19:45:18 +0000 (16:45 -0300)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Fri, 28 Jan 2022 21:18:27 +0000 (18:18 -0300)
commit948ce73b31fdb0860bcec4b8e62b14e88234f98a
tree587bed4b009d25b2304f75ba738b4a3235ad7e8e
parent8fba672472ae0055387e9315fc2eddfa6775ca79
Linux: Only generate 64 bit timestamps for 64 bit time_t recvmsg/recvmmsg

The timestamps created by __convert_scm_timestamps only make sense for
64 bit time_t programs, 32 bit time_t programs will ignore 64 bit time_t
timestamps since SO_TIMESTAMP will be defined to old values (either by
glibc or kernel headers).

Worse, if the buffer is not suffice MSG_CTRUNC is set to indicate it
(which breaks some programs [1]).

This patch makes only 64 bit time_t recvmsg and recvmmsg to call
__convert_scm_timestamps.  Also, the assumption to called it is changed
from __ASSUME_TIME64_SYSCALLS to __TIMESIZE != 64 since the setsockopt
might be called by libraries built without __TIME_BITS=64.  The
MSG_CTRUNC is only set for the 64 bit symbols, it should happen only
if 64 bit time_t programs run older kernels.

Checked on x86_64-linux-gnu and i686-linux-gnu.

[1] https://github.com/systemd/systemd/pull/20567

Reviewed-by: Florian Weimer <fweimer@redhat.com>
include/sys/socket.h
sysdeps/unix/sysv/linux/Makefile
sysdeps/unix/sysv/linux/recvmmsg.c
sysdeps/unix/sysv/linux/recvmsg.c
sysdeps/unix/sysv/linux/tst-socket-timestamp-compat-time64.c [new file with mode: 0644]
sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c [new file with mode: 0644]