[Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.
authorSam McCall <sam.mccall@gmail.com>
Mon, 9 Dec 2019 10:57:23 +0000 (11:57 +0100)
committerSam McCall <sam.mccall@gmail.com>
Mon, 9 Dec 2019 13:34:31 +0000 (14:34 +0100)
commit94603ec11b55ca22b5dbebcfca5e83f313b632e3
treeb2b8cf74954574d58f258783753ff202b86ae279
parentc20930a724f9ecaa6ef4bea819f5ce5115506107
[Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in.

Summary:
Instead, emit a diagnostic and return an empty ASM node, as we do if the target
is missing.

Filter this diagnostic out in clangd, where it's not meaningful.

Fixes https://github.com/clangd/clangd/issues/222

Reviewers: kadircet

Subscribers: mgorny, ilya-biryukov, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D71189
clang-tools-extra/clangd/Diagnostics.cpp
clang-tools-extra/clangd/unittests/CMakeLists.txt
clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
clang/lib/Parse/ParseStmtAsm.cpp