kdb: Gid rid of implicit setting of the current task / regs
authorDouglas Anderson <dianders@chromium.org>
Sat, 9 Nov 2019 19:16:43 +0000 (11:16 -0800)
committerDaniel Thompson <daniel.thompson@linaro.org>
Fri, 31 Jan 2020 17:34:00 +0000 (17:34 +0000)
commit9441d5f6b77770ee388884f04b14a99b028a15e6
tree2061f7a95b10c7ce3f7abf59aecc91069cb879e5
parenta8649fb0a8c1de9c842c9c492f189cabbc468272
kdb: Gid rid of implicit setting of the current task / regs

Some (but not all?) of the kdb backtrace paths would cause the
kdb_current_task and kdb_current_regs to remain changed.  As discussed
in a review of a previous patch [1], this doesn't seem intuitive, so
let's fix that.

...but, it turns out that there's actually no longer any reason to set
the current task / current regs while backtracing anymore anyway.  As
of commit 2277b492582d ("kdb: Fix stack crawling on 'running' CPUs
that aren't the master") if we're backtracing on a task running on a
CPU we ask that CPU to do the backtrace itself.  Linux can do that
without anything fancy.  If we're doing backtrace on a sleeping task
we can also do that fine without updating globals.  So this patch
mostly just turns into deleting a bunch of code.

[1] https://lore.kernel.org/r/20191010150735.dhrj3pbjgmjrdpwr@holly.lan

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20191109111624.4.Ibc3d982bbeb9e46872d43973ba808cd4c79537c7@changeid
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
kernel/debug/kdb/kdb_bt.c
kernel/debug/kdb/kdb_main.c
kernel/debug/kdb/kdb_private.h