audit: call audit_bprm() only once to add AUDIT_EXECVE information
authorRichard Guy Briggs <rgb@redhat.com>
Wed, 30 Oct 2013 22:05:24 +0000 (18:05 -0400)
committerEric Paris <eparis@redhat.com>
Tue, 5 Nov 2013 16:15:03 +0000 (11:15 -0500)
commit9410d228a4cf434305306746bb799fb7acdd8648
tree93dc6f756af3c2557f2e1377bad52582fdd9fe19
parentd9cfea91e97d5d19f9d69beaa844f5fe56a6adc6
audit: call audit_bprm() only once to add AUDIT_EXECVE information

Move the audit_bprm() call from search_binary_handler() to exec_binprm().  This
allows us to get rid of the mm member of struct audit_aux_data_execve since
bprm->mm will equal current->mm.

This also mitigates the issue that ->argc could be modified by the
load_binary() call in search_binary_handler().

audit_bprm() was being called to add an AUDIT_EXECVE record to the audit
context every time search_binary_handler() was recursively called.  Only one
reference is necessary.

Reported-by: Oleg Nesterov <onestero@redhat.com>
Cc: Eric Paris <eparis@redhat.com>
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
---
This patch is against 3.11, but was developed on Oleg's post-3.11 patches that
introduce exec_binprm().
fs/exec.c
include/linux/audit.h
kernel/audit.h
kernel/auditsc.c