mm/highmem: delete memmove_page()
authorFabio M. De Francesco <fmdefrancesco@gmail.com>
Mon, 6 Jun 2022 14:15:33 +0000 (16:15 +0200)
committerakpm <akpm@linux-foundation.org>
Fri, 17 Jun 2022 02:48:29 +0000 (19:48 -0700)
commit9384d79249d04b03572abb7e551a35d99c9268c0
tree02a003587fc361515b3d2df54a0d90c8b7d2de15
parent673520f8da64f16077c1ecb190cbb38aa939fb41
mm/highmem: delete memmove_page()

Matthew Wilcox reported that, while he was looking at memmove_page(), he
realized that it can't actually work.

The reasons are hidden in its implementation, which makes use of memmove()
on logical addresses provided by kmap_local_page().  memmove() does the
wrong thing when it tests "if (dest <= src)".

Therefore, delete memmove_page().

No need to change any other code because we have no call sites of
memmove_page() across the whole kernel.

Link: https://lkml.kernel.org/r/20220606141533.555-1-fmdefrancesco@gmail.com
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Reported-by: Matthew Wilcox <willy@infradead.org>
Reviewed-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/highmem.h