projects / platform / upstream / xorg-server.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 983e303) | patch
dmxConfigCanvasUpdate: Delay dereference until after checking for NULL
authorAlan Coopersmith <alan.coopersmith@oracle.com>
Mon, 21 Apr 2014 22:18:45 +0000 (15:18 -0700)
committerKeith Packard <keithp@keithp.com>
Tue, 22 Apr 2014 03:54:22 +0000 (20:54 -0700)
commit935ea0d7b5e18ad8f22ee074a08cbdc7390d0f5d
treed163ae74007b9b976d9142febd2472064091f3e4tree | snapshot
parent983e30361f49a67252d0b5d82630e70724d69dbfcommit | diff
dmxConfigCanvasUpdate: Delay dereference until after checking for NULL

Flagged by cppcheck 1.64:
[hw/dmx/config/xdmxconfig.c:306] -> [hw/dmx/config/xdmxconfig.c:323]:
 (warning) Possible null pointer dereference: fs - otherwise
           it is redundant to check it against null.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
Signed-off-by: Keith Packard <keithp@keithp.com>
hw/dmx/config/xdmxconfig.c diff | blob | history
Domain: Graphics System / X Window System;