bpf: Clarify error expectations from bpf_clone_redirect
authorStanislav Fomichev <sdf@google.com>
Mon, 11 Sep 2023 19:47:30 +0000 (12:47 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Oct 2023 12:56:55 +0000 (14:56 +0200)
commit92f24f98d5ff65c59a2b3c6fa30d38e8cc941d4d
treefbc0afdd6489f26e90c382fe4b6ca67389c9e9dd
parent60446b5e74865acff1af5f2d89d99551c8e6e2c1
bpf: Clarify error expectations from bpf_clone_redirect

[ Upstream commit 7cb779a6867fea00b4209bcf6de2f178a743247d ]

Commit 151e887d8ff9 ("veth: Fixing transmit return status for dropped
packets") exposed the fact that bpf_clone_redirect is capable of
returning raw NET_XMIT_XXX return codes.

This is in the conflict with its UAPI doc which says the following:
"0 on success, or a negative error in case of failure."

Update the UAPI to reflect the fact that bpf_clone_redirect can
return positive error numbers, but don't explicitly define
their meaning.

Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20230911194731.286342-1-sdf@google.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/uapi/linux/bpf.h
tools/include/uapi/linux/bpf.h