libstdc++: Fix self-move for std::weak_ptr [PR108118]
authorJonathan Wakely <jwakely@redhat.com>
Thu, 15 Dec 2022 09:52:48 +0000 (09:52 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Fri, 16 Dec 2022 12:59:08 +0000 (12:59 +0000)
commit92eb0adc14a5f84acce7e5bc780b81b1544b24aa
treec306b29be2c436f34a1dfffa48e0d909d2cab204
parentd386d399205e68e02b357dfcd96b9a4b91e4f295
libstdc++: Fix self-move for std::weak_ptr [PR108118]

I think an alternative fix would be something like:

  _M_ptr = std::exchange(rhs._M_ptr, nullptr);
  _M_refcount = std::move(rhs._M_refcount);

The standard's move-and-swap implementation generates smaller code at
all levels except -O0 and -Og, so it seems simplest to just do what the
standard says.

libstdc++-v3/ChangeLog:

PR libstdc++/108118
* include/bits/shared_ptr_base.h (weak_ptr::operator=):
Implement as move-and-swap exactly as specified in the standard.
* testsuite/20_util/weak_ptr/cons/self_move.cc: New test.
libstdc++-v3/include/bits/shared_ptr_base.h
libstdc++-v3/testsuite/20_util/weak_ptr/cons/self_move.cc [new file with mode: 0644]