[trace] Fix destructor declaration
authorWalter Erquinigo <wallace@fb.com>
Tue, 29 Sep 2020 20:08:22 +0000 (13:08 -0700)
committerWalter Erquinigo <wallace@fb.com>
Tue, 29 Sep 2020 20:09:52 +0000 (13:09 -0700)
commit92e1ebeaa1fe0e5461327d071c55167733834e60
tree478e1cf7b4dcdd3d7f9d4eaeb7c54d357c7067b9
parentd94253b52eb1ccf08daaa281488b3903396ca9b9
[trace] Fix destructor declaration

The destructor must be defined in the implementation class so that it
can be called, as Vedant Kumar pointed out in:

'''
What were your thoughts, re:

+class Trace : public PluginInterface {
+public:
+  ~Trace() override = default;

   Does this need to be `virtual ~Trace() = ...`?

      Otherwise, when a std::shared_ptr<Trace> is destroyed, the
      destructor for the derived TraceIntelPT instance won't run.
'''
lldb/include/lldb/Target/Trace.h
lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h