(backport) Fix format-truncation compile failure by typecasting USB IDs (#8250)
authorPatrick Uiterwijk <patrick@puiterwijk.org>
Thu, 22 Feb 2018 18:41:30 +0000 (19:41 +0100)
committerAdrian Szyndela <adrian.s@samsung.com>
Wed, 26 Feb 2020 10:39:00 +0000 (11:39 +0100)
commit92a796aaa622a5c7ca7d2360a3a0b3dce2c4cf4d
treefeecb0c276db08fdc6b77915705d40dae44320c1
parentde15a1bdad48788116c0e2588b67b4d4ac8bd3ab
(backport) Fix format-truncation compile failure by typecasting USB IDs (#8250)

This patch adds safe_atoux16 for parsing an unsigned hexadecimal 16bit int, and
uses that for parsing USB device and vendor IDs.

This fixes a compile error with gcc-8 because while we know that USB IDs are 2 bytes,
the compiler does not know that.

../src/udev/udev-builtin-hwdb.c:80:38: error: '%04X' directive output may be
truncated writing between 4 and 8 bytes into a region of size between 2 and 6
[-Werror=format-truncation=]

Change-Id: I40b2eb8b424c57ba430b217ebead2fc5d67bbb14
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
src/basic/parse-util.c
src/basic/parse-util.h
src/test/test-parse-util.c
src/udev/udev-builtin-hwdb.c