drm/i915/snb+: Remove incorrect forcewake check in debugfs/i915_drpc_info
authorImre Deak <imre.deak@intel.com>
Thu, 8 Feb 2018 11:23:31 +0000 (13:23 +0200)
committerImre Deak <imre.deak@intel.com>
Fri, 9 Feb 2018 15:37:21 +0000 (17:37 +0200)
commit928f0cd0eb0511e19b416e34a030ebff6785fa52
treee1677244cfaf49cb4a9fe0c9652ad404faa3de2b
parent8e47b4b65bbd646b4d8be28e1ffff7a684f60fe6
drm/i915/snb+: Remove incorrect forcewake check in debugfs/i915_drpc_info

FORCEWAKE_ACK is depricated by BSpec at least starting from BDW,
referring to the multi-threaded version of it instead. Accessing
FORCEWAKE_ACK triggers an unclaimed register access error - at
least on GLK - see the Reference: below.

The correct registers to use would be FORCEWAKE_MT_ACK on IVB+ and
FORCEWAKE_ACK_RENDER_GEN9 on SKL+ like it's done elsewhere in the
driver.

The forcewake check itself is inconsistent and redundant, since there
could be other forcewake requesters besides the kernel (being the
multithreaded version of the register) and the kernel's per-domain
forcewake counters are shown anyway at the end of the file. So let's
just remove the check.

Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reference: https://bugs.freedesktop.org/show_bug.cgi?id=103337
Signed-off-by: Imre Deak <imre.deak@intel.com>
Tested-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20180208112331.12986-1-imre.deak@intel.com
drivers/gpu/drm/i915/i915_debugfs.c