qed: fix link config error handling
authorArnd Bergmann <arnd@arndb.de>
Fri, 2 Nov 2018 15:36:24 +0000 (16:36 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 4 Nov 2018 02:27:33 +0000 (19:27 -0700)
commit92619210529a6b77b2cbedbadba3ff5eaa6e28ed
tree75d341c7fdb4c8a81d784cd33b6ce573ad4b3bf7
parente8ccbb7d2f53c62e14b889faaa3f6f809b657278
qed: fix link config error handling

gcc-8 notices that qed_mcp_get_transceiver_data() may fail to
return a result to the caller:

drivers/net/ethernet/qlogic/qed/qed_mcp.c: In function 'qed_mcp_trans_speed_mask':
drivers/net/ethernet/qlogic/qed/qed_mcp.c:1955:2: error: 'transceiver_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]

When an error is returned by qed_mcp_get_transceiver_data(), we
should propagate that to the caller of qed_mcp_trans_speed_mask()
rather than continuing with uninitialized data.

Fixes: c56a8be7e7aa ("qed: Add supported link and advertise link to display in ethtool.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_mcp.c