[ICP] Do not attempt type matching for variable length arguments.
authorTaewook Oh <twoh@fb.com>
Wed, 25 Apr 2018 17:19:21 +0000 (17:19 +0000)
committerTaewook Oh <twoh@fb.com>
Wed, 25 Apr 2018 17:19:21 +0000 (17:19 +0000)
commit923c216da572e93dc732478a2cad59929ec7c544
tree2c213822cdd90850e1dd2d9285af05d5a78c8c8b
parent79c6ec484eb0a6dcf9b0aec92174745f094e8d23
[ICP] Do not attempt type matching for variable length arguments.

Summary:
When performing indirect call promotion, current implementation inspects "all" parameters of the callsite and attemps to match with the formal argument type of the callee function. However, it is not possible to find the type for variable length arguments, and the compiler crashes when it attemps to match the type for variable lenght argument.

It seems that the bug is introduced with D40658. Prior to that, the type matching is performed only for the parameters whose ID is less than callee->getFunctionNumParams(). The attached test case will crash without the patch.

Reviewers: mssimpso, davidxl, davide

Reviewed By: mssimpso

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D46026

llvm-svn: 330844
llvm/lib/Transforms/Utils/CallPromotionUtils.cpp
llvm/test/Transforms/PGOProfile/indirect_call_promotion_vla.ll [new file with mode: 0644]